Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

4779_make_getmac_threadsafe #4780

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

4779_make_getmac_threadsafe #4780

wants to merge 1 commit into from

Conversation

douggie
Copy link
Collaborator

@douggie douggie commented Oct 16, 2023

@douggie
Copy link
Collaborator Author

douggie commented Oct 16, 2023

These test failures are unrelated, seems like an issue with develop.

@douggie douggie mentioned this pull request Nov 8, 2023
Closed
@rizer1980
Copy link
Contributor

it's seems that some error in(kraken futures)

  1. no BTC in https://futures.kraken.com/derivatives/api/v3/instruments response (very strange)
  2. lower case parsing "pf" prefix in adaptInstrumentsMetaData method
    trying to deep in...
    @makarid ?

@rizer1980
Copy link
Contributor

I think I fixed it
post PR a little bit later

@rizer1980
Copy link
Contributor

done
#4787

@rizer1980
Copy link
Contributor

@douggie
is this fix just in case?
or is there code that does not work without this change?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@douggie @rizer1980