setXAxisMaxLabelCount() not to affect Y Axis in HeatMapCharts #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me look at it once I have a moment. Maybe we can increase the visibility. |
|
@timmolter any opinion on the unit test here? |
|
it looks like it made the build fail: https://github.com/knowm/XChart/runs/4121420139?check_suite_focus=true |
|
Yep. Looking into it. I wonder why didn't the branch-build catch it then? |
This was referenced Nov 5, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #564.
Note that the unit test code looks somewhat ugly due to it using reflection to get to private fields (axisPair, yAxis). An alternative would be to increase the visibility for these two members. I am not sure if a unit test is a good enough reason for that.