Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

replace pkg_resources for python 3.12 #420

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Conversation

branchvincent
Copy link
Contributor

Python 3.12 has removed bundled setuptools (aka pkg_resources): https://docs.python.org/3.12/whatsnew/3.12.html#removed

Also

  • Bump python_requires to 3.8+ (see commit, alternatively can depend on importlib_metadata backport on pypi)
  • Fixes SyntaxWarning's introduced from invalid escape sequences

@wh0am1i
Copy link
Collaborator

wh0am1i commented Apr 28, 2024

thanks for you pull requests, but some checks failed. We will fix it, Please resubmit after fixing.

@wh0am1i
Copy link
Collaborator

wh0am1i commented Apr 28, 2024

hello, you can run git pull and marge master branch, then resubmit,thanks!

python <3.8 is unsupported and would now need the importlib_metadata backport
As shown with `python3.12 -m compileall -f $(git ls-files '*.py')`
@branchvincent
Copy link
Contributor Author

@wh0am1i done!

@rungobier rungobier merged commit 2c0a105 into knownsec:master Apr 29, 2024
8 checks passed
@branchvincent branchvincent deleted the 3.12 branch April 29, 2024 02:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants