This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Autodetect defmt usage #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
that referenced
this pull request
Jan 7, 2021
129: reject use of defmt and --no-flash (again) r=japaric a=japaric before PR #105 using defmt required the `--defmt` flag. At that time it was not possible to use the `--defmt` and `--no-flash` flags together. The rationale for that restriction is that without it `cargo run` can invoke `probe-run` with a newer version of the ELF different from the ELF that was last flashed on the device and that can result in log messages that make no sense and/or decoder errors. After PR 105 landed it unintentionally became possible to use defmt with --no-flash due to the auto-detection (auto-enable) mechanism. This PR corrects that and makes the use of `--no-flash` flag and defmt an error again. Co-authored-by: Jorge Aparicio <jorge.aparicio@ferrous-systems.com>
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #102