This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 75
limit backtrace length, make limit configurable #179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1021ec4
to
c7710b6
Compare
Lotterleben
commented
Mar 31, 2021
jonas-schievink
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only some minor nits (and this needs a cargo fmt
)
94d256f
to
89ceeab
Compare
Adjusted and squashed :) |
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 31, 2021
179: limit backtrace length, make limit configurable r=Lotterleben a=Lotterleben mitigation for #127 example run with user-configured limit: ```console ➜ probe-run git:(127-fix-infinte-loop) ✗ cr -- --max-backtrace-len=3 --chip nRF52840_xxAA rtc_async.elf Compiling probe-run v0.2.1 (/Users/lottesteenbrink/ferrous/knurling/probe-run) Finished dev [unoptimized + debuginfo] target(s) in 6.64s Running `target/debug/probe-run --max-backtrace-len=3 --chip nRF52840_xxAA rtc_async.elf` (HOST) INFO flashing program (11.52 KiB) (HOST) INFO success! ──────────────────────────────────────────────────────────────────────────────── 0 INFO Hello World! └─ rtc_async::__cortex_m_rt_main @ /home/dirbaio/akiles/embassy/embassy-nrf-examples/src/bin/rtc_async.rs:42 1 INFO tick └─ rtc_async::run2::task::{{closure}} @ /home/dirbaio/akiles/embassy/embassy-nrf-examples/src/bin/rtc_async.rs:31 2 INFO BIG INFREQUENT TICK └─ rtc_async::run1::task::{{closure}} @ /home/dirbaio/akiles/embassy/embassy-nrf-examples/src/bin/rtc_async.rs:22 3 INFO tick └─ rtc_async::run2::task::{{closure}} @ /home/dirbaio/akiles/embassy/embassy-nrf-examples/src/bin/rtc_async.rs:31 4 INFO tick └─ rtc_async::run2::task::{{closure}} @ /home/dirbaio/akiles/embassy/embassy-nrf-examples/src/bin/rtc_async.rs:31 5 INFO tick └─ rtc_async::run2::task::{{closure}} @ /home/dirbaio/akiles/embassy/embassy-nrf-examples/src/bin/rtc_async.rs:31 6 INFO tick └─ rtc_async::run2::task::{{closure}} @ /home/dirbaio/akiles/embassy/embassy-nrf-examples/src/bin/rtc_async.rs:31 ──────────────────────────────────────────────────────────────────────────────── stack backtrace: 0: HardFaultTrampoline <exception entry> 1: rtc_async::run1::task::{{closure}} at /home/dirbaio/akiles/embassy/embassy-nrf-examples/src/bin/rtc_async.rs:24 2: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll at /home/dirbaio/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/future/mod.rs:80 3: embassy::executor::Task<F>::poll at /home/dirbaio/akiles/embassy/embassy/src/executor/mod.rs:71 (HOST) WARN Maximum backtrace length of 3 reached; cutting off the rest note: re-run with `--max-backtrace-len=<your maximum>` to extend this limit (HOST) ERROR the program panicked ``` Co-authored-by: Lotte Steenbrink <lotte.steenbrink@ferrous-systems.com>
Build failed: |
Ah dang, got a little bit ahead of myself there– structopts |
89ceeab
to
9fb4786
Compare
bors r+ |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mitigation for #127
example run with user-configured limit: