Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

backtrace: highlight frames that point to local code #200

Merged
merged 1 commit into from
May 12, 2021

Conversation

japaric
Copy link
Member

@japaric japaric commented May 12, 2021

using the heuristic: if the file location of the function is relative to the current directory then
it's "local code"

before:
Screenshot from 2021-05-12 18-47-40
after:
Screenshot from 2021-05-12 18-46-03

I don't have too many opinions about how to highlight these frames so treat the above as a strawman proposal

cc #139 @Lotterleben

using the heuristic: if the file location of the function is relative to the current directory then
it's "local code"
@jonas-schievink
Copy link
Contributor

As a followup, we might be able to check if the path is part of the containing Cargo workspace instead, that might improve the accuracy a bit.

bors r+

@bors bors bot merged commit 29cee30 into main May 12, 2021
@bors bors bot deleted the backtrace-highlight-local-code branch May 12, 2021 17:29
@Lotterleben
Copy link

This is brilliant!

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants