This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
extend --shorten-paths; highlight path segments
#210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit extends `--shorten-paths` so it now also handles: - `/rustc` paths - `rust-std` paths it also adds highlighting to paths when `--shorten-paths` is not used
japaric
commented
May 20, 2021
|
|
||
| assert_eq!(expected, path); | ||
|
|
||
| let expected_str = "[stable]/library/core/src/sync/atomic.rs"; |
There was a problem hiding this comment.
the picture in the PR description doesn't show how a rust-std path is compressed but this test does
japaric
commented
May 20, 2021
| use rstest::rstest; | ||
|
|
||
| #[rstest] | ||
| #[case("stable-x86_64-unknown-linux-gnu", Channel::Stable, "stable")] |
There was a problem hiding this comment.
the picture in the PR description doesn't show how a
rust-stdpath is compressed but this test does
and this is how the toolchains are shortened with --shorten-paths
Urhengulas
reviewed
May 20, 2021
Co-authored-by: Johann Hemmann <johann.hemmann@code.berlin>
|
Looks good to me and I like the shortening! 😄 I think I would like to have this enabled per default and a flag for printing the long paths, but this is a story for another PR :D |
|
bors r=Urhengulas |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit extends
--shorten-pathsso it now also handles:/rustcpathsrust-stdpathsit also adds highlighting to paths when
--shorten-pathsis not usedwithout
--shorten-pathswith
--shorten-pathscloses #66