This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Print dedicated message on control + c #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lotterleben
changed the title
Lotterleben
force-pushed
the
231-ctrl-c-msg
branch
from
c308cdf to
e21e6f4
Compare
|
@ test failure: welp.. yeah. I could've thought of that. -.- |
Lotterleben
commented
Aug 18, 2021
| } | ||
| } | ||
|
|
||
| #[cfg(target_family = "unix")] |
There was a problem hiding this comment.
from what I understand so far, simulating a ctrl+c on windows is a bit finicky (you'd probably use the winapi crate which is a bit underdocumented?) and I don't have a windows machine at hand to play with this so I opted for this makeshift solution
added 6 commits
September 7, 2021 16:14
Lotterleben
force-pushed
the
231-ctrl-c-msg
branch
from
a966dc7 to
650a33b
Compare
Lotterleben
force-pushed
the
231-ctrl-c-msg
branch
from
650a33b to
a76b9ae
Compare
|
Nice work! bors r+ |
|
Build succeeded: |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #231 , but in a slightly awkward way– imo
halted_due_to_signalshould be merged intoOutcomebut that's a bigger rabbithole and I wanted to open this PR first to get some general feedback and then tackle that in either this or a follow-up PR.This PR also adds a test for this new functionality.
I've slightly refactored our test helpers to accommodate the need for a "run and terminate" option. To ensure that tests still run sequentially, I'be switched them to serial_test.
While I was at it, I also fixed 2 typos I came across.