Skip to content
This repository was archived by the owner on Jan 30, 2024. It is now read-only.

Actually deregister the Ctrl+C handler #51

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Actually deregister the Ctrl+C handler #51

merged 1 commit into from
Sep 2, 2020

Conversation

jonas-schievink
Copy link
Contributor

No description provided.

@jonas-schievink jonas-schievink mentioned this pull request Sep 2, 2020
Merged
@kaspar030
Copy link

This let's me correctly break out of the loop in #46 using ctrl-c!

japaric
japaric approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I thought we were using the ctrlc crate) Not familiar with this crate but I trust you.

@jonas-schievink
Copy link
Contributor Author

I switched to signal_hook since ctrlc does not support deregistering the handler at all

@jonas-schievink jonas-schievink merged commit 4c7a543 into main Sep 2, 2020
@jonas-schievink jonas-schievink deleted the really-deregister-handler branch September 2, 2020 11:51
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@japaric japaric japaric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonas-schievink @kaspar030 @japaric