Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Koa v3 Tracker #1837

Open
4 of 13 tasks
jonathanong opened this issue Aug 29, 2024 · 4 comments
Open
4 of 13 tasks

Koa v3 Tracker #1837

jonathanong opened this issue Aug 29, 2024 · 4 comments

Comments

@jonathanong
Copy link
Member

jonathanong commented Aug 29, 2024

Starting a new tracker for v3

Milestone: https://github.com/koajs/koa/milestone/4

Other Breaking Changes:

Future:

  • Deno support
  • Bun support
  • Rewrite in TypeScript

Tests:

  • Migrate to jest
  • Properly close down server after each test run

Improved Documentation:

@jaydenseric
Copy link

Regarding the goal to move to Jest; please don't. Use the native Node.js test runner! It should be more than adequate.

You can pair it with coverage-node, a very lightweight CLI tool, to enforce 100% code coverage in tests:

https://github.com/jaydenseric/coverage-node

@talentlessguy
Copy link

to add, Node test runner has identical API to Jest

for assertion, node:assert could be used

@benmccann
Copy link

Vitest is another fairly lightweight option for jest-compatible test runner. My last experience was that Jest is terrible to use with ESM as it doesn't fully support it yet. vitest is much better in this regard.

A rewrite might also be a nice time to take a look at including only minimal dependencies (e.g. https://npmgraph.js.org/?q=koa vs https://npmgraph.js.org/?q=polka)

@jonathanong
Copy link
Member Author

I just realized that I already migrated it to jest a while go haha. if anyone is interested in migrating to node's official test runner, that would be great. otherwise, I will leave it as is

@sirenkovladd sirenkovladd mentioned this issue Sep 20, 2024
6 tasks
@koajs koajs deleted a comment from iietmoon Oct 20, 2024
kevinpeno pushed a commit that referenced this issue Oct 28, 2024
## Checklist
use `node --test` instead of `jest`
See: #1837 (comment)

- [X] I have ensured my pull request is not behind the main or master
branch of the original repository.
- [X] I have rebased all commits where necessary so that reviewing this
pull request can be done without having to merge it first.
- [X] I have written a commit message that passes commitlint linting.
- [X] I have ensured that my code changes pass linting tests.
- [X] I have ensured that my code changes pass unit tests.
- [X] I have described my pull request and the reasons for code changes
along with context if necessary.
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants