fix(sso): 500 on admin login (#5334) #5363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a 500 being thrown when a non-superuser goes to /admin and then tries to log in as a superuser. Upgrade django-allauth to 65.1.0. The simplest solution seemed to be just to upgrade django-allauth. It's unclear which exact commit fixes the bug and we are very behind in versions so upgraded to the latest. Nothing obvious broke except one unit test. Bug template: 1. ℹ️ Have 2 accounts, one super and one not 2. Log in as the non-superuser 3. Go to /admin 4. You should be redirected to the login page. 5. Log in as the super user 6. 🔴 [on main] 500 error 7. Checkout the PR branch. Make sure to reinstall requirements. 8. Do 1-5 again. 9. 🟢 [on PR] You should be correctly logged in and sent to the admin page
noliveleger
approved these changes
Dec 17, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of kpi#5334