Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(NLP): missing suggested language in language selector DEV-17 #5559

Merged

Conversation

magicznyleszek
Copy link
Member

@magicznyleszek magicznyleszek commented Feb 27, 2025

💭 Notes

Loop of asynchronous calls was bad. I made Promise.all that fixes the problem.

👀 Preview steps

I can reproduce this on kf.main but I believe this is on production too.

  1. Create a form with one audio question
  2. Create two submissions (each with one audio file)
  3. From the data table, click Open for the first submission.
  4. Create a manual transcription in English. Save it.
  5. Delete the transcript.
  6. Go to the second submission (from the data table or by just clicking the up/down button from the same screen).
  7. Create a manual transcription in Spanish. Save it.
  8. Go back to the first subscription. Try to create a new transcript in English.

Expected behavior: The top of the language list shows English in the first position.

Instead: English is not displayed at all (and can't be found by searching either). Spanish is displayed in first position.

@magicznyleszek magicznyleszek self-assigned this Feb 27, 2025
@magicznyleszek magicznyleszek changed the title fix(NLP): fetchSuggestedLanguages not working correctly for multiple languages fix(NLP): fetchSuggestedLanguages not working correctly for multiple languages DEV-17 Feb 27, 2025
@magicznyleszek magicznyleszek changed the title fix(NLP): fetchSuggestedLanguages not working correctly for multiple languages DEV-17 fix(NLP): missing suggested language in language selector DEV-17 Feb 27, 2025
@magicznyleszek magicznyleszek marked this pull request as ready for review February 28, 2025 10:58
Copy link
Contributor

@Akuukis Akuukis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code LGTM, see style nitpicks inline.

✅ happy path tested previewed:

  • reproduced the bug on the main
  • reproduced the bug on the commit before PR
  • reproduced the expected behavior on PR

⚠️ did not stumble upon errors so that's not previewed.

magicznyleszek and others added 2 commits March 3, 2025 12:02
Co-authored-by: Akuukis <Akuukis@users.noreply.github.com>
@magicznyleszek magicznyleszek merged commit 674031f into release/2.025.02 Mar 3, 2025
7 checks passed
@magicznyleszek magicznyleszek deleted the leszek/2.025.02-languages-bug-fix-dev-17 branch March 3, 2025 12:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants