Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve tooltip position in all nivo charts #108

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

ricoberger
Copy link
Member

Until now it was possible that the tooltip in the nivo charts wasn't
completly visible. That should be fixed now. For that we are checking if
the point for which the tooltip is shown is in the first half or second
half of the chart. If it is in the first half the tooltip will be
displayed on the right of the cursor and if it is in the second half the
tooltip will be displayed on the right of the cursor.

We also apply the roundNumber function, which was introduced in #107, in
the table component of the Prometheus plugin.

The "/api/health" endpoint is now excluded from all middlewares. This
was changed, so that we do not spam metrics and logs with the values for
this enpoint, because it makes finding the right logs in a Kubernetes
environment with regular health check difficult.

Last but not least we updated all the NPM packages, which we are using
in the plugins.

Until now it was possible that the tooltip in the nivo charts wasn't
completly visible. That should be fixed now. For that we are checking if
the point for which the tooltip is shown is in the first half or second
half of the chart. If it is in the first half the tooltip will be
displayed on the right of the cursor and if it is in the second half the
tooltip will be displayed on the right of the cursor.

We also apply the roundNumber function, which was introduced in #107, in
the table component of the Prometheus plugin.

The "/api/health" endpoint is now excluded from all middlewares. This
was changed, so that we do not spam metrics and logs with the values for
this enpoint, because it makes finding the right logs in a Kubernetes
environment with regular health check difficult.

Last but not least we updated all the NPM packages, which we are using
in the plugins.
@ricoberger ricoberger merged commit 2e412ca into main Aug 11, 2021
@ricoberger ricoberger deleted the improve-tooltip-position-in-charts branch August 11, 2021 20:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant