Improve reliability of kobs #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the reliability of kobs, be not checking the database connection in the ClickHouse instance after a new instance was created. In this way kobs can also start, when the configured ClickHouse instance is temporarly unavailable. We also fixed a small bug, where we forgot to stop the goroutine which writes a new line for long running queries, when an error occured.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the reliability of kobs, be not checking the
database connection in the ClickHouse instance after a new instance was
created. In this way kobs can also start, when the configured ClickHouse
instance is temporarly unavailable.
We also fixed a small bug, where we forgot to stop the goroutine which
writes a new line for long running queries, when an error occured.