Adjust chart handling across plugins #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We moved some of the components and objects we need for the nivo chart package to the core plugin, so that we can reuse the functions across all our plugins. We also did the same for the colors functions which were used by several plugins. Besides that we improved also the styling of the LogsChart in the ClickHouse plugin, so that it looks like all our other charts and we renamed the visualization API endpoint to aggregations.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We moved some of the components and objects we need for the nivo chart
package to the core plugin, so that we can reuse the functions across
all our plugins. We also did the same for the colors functions which
were used by several plugins.
Besides that we improved also the styling of the LogsChart in the
ClickHouse plugin, so that it looks like all our other charts and we
renamed the visualization API endpoint to aggregations.