[clickhouse] Fix returned logs for custom order #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug, that we returned the wrong logs, when a user selected a custom order for the results. This was caused by our optimization of the time range for the raw logs query by the results of the bucket query. To fix this bug, we have adjusted the logic to adjust the time range for the raw logs query, based on the buckets. We are using the existing logic only for the default order "timestamp DESC". For "timestamp ASC" order we are looping the other way around through the buckets. For each other orders we skip the optimization based on the given limit.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug, that we returned the wrong logs, when a user selected a
custom order for the results. This was caused by our optimization of the
time range for the raw logs query by the results of the bucket query.
To fix this bug, we have adjusted the logic to adjust the time range for
the raw logs query, based on the buckets. We are using the existing
logic only for the default order "timestamp DESC". For "timestamp ASC"
order we are looping the other way around through the buckets. For each
other orders we skip the optimization based on the given limit.