[resources] Use TableComposable instead of Table #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are now using the TableComposable component instead of the Table component to display Kubernetes resources, so that we are finally removed the Table component from all places were it was used. We also adjusted the style of hoverable / selectable tables across several plugins, so that the selected row (the row which is shown in the details) is now correctly highlighted.
ricoberger
added a commit
that referenced
this pull request
Dec 22, 2021
This commit fixes the sync action in the Flux plugin for Kustomizations and Helm Releases. After #235 we forgot to adjust the sync action, so that the cluster, namespace and name of the Kustomization / Helm Release was "undefined" in the action. Therefore the API call failed, because the resource was not found and an error was shown to the user. We also changed the behaviour of the "Search" button, so that the resources are always reloaded, when the user clicks the button.
ricoberger
added a commit
that referenced
this pull request
Dec 22, 2021
This commit fixes the sync action in the Flux plugin for Kustomizations and Helm Releases. After #235 we forgot to adjust the sync action, so that the cluster, namespace and name of the Kustomization / Helm Release was "undefined" in the action. Therefore the API call failed, because the resource was not found and an error was shown to the user. We also changed the behaviour of the "Search" button, so that the resources are always reloaded, when the user clicks the button.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now using the TableComposable component instead of the Table
component to display Kubernetes resources, so that we are finally
removed the Table component from all places were it was used.
We also adjusted the style of hoverable / selectable tables across
several plugins, so that the selected row (the row which is shown in the
details) is now correctly highlighted.