[core] Refactor frontend code of plugins #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are going back to the implementation based on "useEffect" for the options handling, instead of the "useMemo" handling, introduced in #232.
We had a mixed usage of "setDetails" and "showDetails" across plugins. To clean this up we are now only using "setDetails".
To have the same nameing as for the panel implementation we renamed options to pluginOptions for the page implementation of a plugin.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
options handling, instead of the "useMemo" handling, introduced in [core] Change options handling for various plugins #232.
To clean this up we are now only using "setDetails".
options to pluginOptions for the page implementation of a plugin.