[resources] Fix reload of resources #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes that resources were not reloaded when a user clicks on the search button, without changing the selected clusters, namespaces or resources. This bug was caused, because we forgot to add the time parameters, which are returned within the search function, to the url. So that the update of the options was not triggered via our "useEffect" hook. The same problem was also present in the applications plugin, which is also fixed with this commit.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes that resources were not reloaded when a user clicks on the
search button, without changing the selected clusters, namespaces or
resources. This bug was caused, because we forgot to add the time
parameters, which are returned within the search function, to the url.
So that the update of the options was not triggered via our "useEffect"
hook.
The same problem was also present in the applications plugin, which is
also fixed with this commit.