[klogs] Fix out of time range documents #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug in the klogs plugin, where it could happen that the returned documents were not in the users selected time range. This was caused by the buckets we determine before the actual query, were the bucket timestamp could be not within the selected time range. We also improved the test coverage for the klogs plugin and unify the style of the used "table" tests.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in the klogs plugin, where it could happen that
the returned documents were not in the users selected time range. This
was caused by the buckets we determine before the actual query, were the
bucket timestamp could be not within the selected time range.
We also improved the test coverage for the klogs plugin and unify the
style of the used "table" tests.