[jaeger] Add new "publicAddress" option #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new "publicAddress" option in the Jaeger plugin configuration, can be used to define the address of a Jaeger UI instance, which can be accessed by the users. If this option is set, we add a link to each trace, which allows the users to open the trace in the Jaeger UI.
We are now saving the state of all spans, if they are expanded or not. This ways we can also render an expanded span, when the user scrolled the span out of the viewport and when he later scrolls back to the expanded span. Before this change, the span was not expanded anymore, when the user scrolls through the list of spans.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new "publicAddress" option in the Jaeger plugin configuration, can
be used to define the address of a Jaeger UI instance, which can be
accessed by the users. If this option is set, we add a link to each
trace, which allows the users to open the trace in the Jaeger UI.
We are now saving the state of all spans, if they are expanded or not.
This ways we can also render an expanded span, when the user scrolled
the span out of the viewport and when he later scrolls back to the
expanded span.
Before this change, the span was not expanded anymore, when the user
scrolls through the list of spans.