[helm] Remove helm.sh/helm/v3 package #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricoberger
force-pushed
the
helm-remove-helm-package-as-dependency
branch
from
ff4aa37 to
9fafd0a
Compare
We decided to remove the "helm.sh/helm/v3" package in the Helm plugin. Instead we are using a custom logic to get the Helm releases from the Kubernetes API. These custom logic involves the following steps: - List all secrets with "owner=helm" - Loop through all returned secrets and decode the "release" key - Decompress the decoded release data an parse them into the Release struct We decided to use our own logic, because we had some problems with the official Helm package and our cluster logic. This leads to a not so satisfying experience during the development. Besides that we are now displaying the "values.yaml" file in the templates section in the frontend and we are using "isInline" for the Alert component when it is rendered in a Card component.
ricoberger
force-pushed
the
helm-remove-helm-package-as-dependency
branch
from
9fafd0a to
52cc9be
Compare
Codecov Report
@@ Coverage Diff @@
## main #281 +/- ##
==========================================
+ Coverage 42.96% 44.45% +1.48%
==========================================
Files 94 95 +1
Lines 7927 7968 +41
==========================================
+ Hits 3406 3542 +136
+ Misses 4490 4394 -96
- Partials 31 32 +1
Continue to review full report at Codecov.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to remove the "helm.sh/helm/v3" package in the Helm plugin.
Instead we are using a custom logic to get the Helm releases from the
Kubernetes API. These custom logic involves the following steps:
struct
We decided to use our own logic, because we had some problems with the
official Helm package and our cluster logic. This leads to a not so
satisfying experience during the development.
Besides that we are now displaying the "values.yaml" file in the
templates section in the frontend and we are using "isInline" for the
Alert component when it is rendered in a Card component.