Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

⚠️ [app] Implement Authentication #406

Merged
merged 4 commits into from
Aug 17, 2022

Conversation

ricoberger
Copy link
Member

@ricoberger ricoberger commented Jul 31, 2022

Instead of relying on a third party service like OAtuh2 Proxy for
authenticating users, we are now supporting authentication of users
directly within kobs.

Users can be authenticated using a static list of email and password
combinations or via OIDC.

In #402 we updated all Go packages. This commit updates all NPM
packages, GitHub Actions and Docker Images.
Instead of relying on a third party service like OAtuh2 Proxy for
authenticating users, we are now supporting authentication of users
directly within kobs.

Users can be authenticated using a static list of email and password
combinations or via OIDC.
@ricoberger ricoberger force-pushed the app-spike-implement-authentication branch from 1740626 to 3e80dd8 Compare July 31, 2022 13:58
@codecov-commenter
Copy link

Codecov Report

Merging #406 (3e80dd8) into main (7b653d2) will decrease coverage by 0.10%.
The diff coverage is 67.27%.

@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
- Coverage   47.31%   47.21%   -0.11%     
==========================================
  Files         138      136       -2     
  Lines       11438    11514      +76     
==========================================
+ Hits         5412     5436      +24     
- Misses       5887     5938      +51     
- Partials      139      140       +1     
Impacted Files Coverage Δ
cmd/kobs/hub/hub.go 0.00% <0.00%> (ø)
pkg/hub/api/applications/applications.go 100.00% <ø> (ø)
pkg/hub/api/applications/topology.go 0.00% <ø> (ø)
pkg/hub/api/notifications/notifications.go 100.00% <ø> (ø)
pkg/hub/api/plugins/plugins.go 0.00% <ø> (ø)
pkg/hub/api/resources/resources.go 0.00% <ø> (ø)
pkg/hub/api/teams/teams.go 100.00% <ø> (ø)
pkg/hub/api/users/users.go 61.72% <ø> (ø)
pkg/hub/auth/context/context.go 100.00% <ø> (ø)
pkg/hub/auth/jwt/jwt.go 96.42% <ø> (ø)
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@ricoberger ricoberger changed the title App spike implement authentication [app] Implement Authentication Aug 1, 2022
@ricoberger ricoberger force-pushed the app-spike-implement-authentication branch from 194ddf7 to 45b1a4b Compare August 17, 2022 19:14
@ricoberger ricoberger force-pushed the app-spike-implement-authentication branch 2 times, most recently from 3339ff0 to b8be451 Compare August 17, 2022 19:31
@ricoberger ricoberger marked this pull request as ready for review August 17, 2022 19:32
@ricoberger ricoberger force-pushed the app-spike-implement-authentication branch from b8be451 to aabb18a Compare August 17, 2022 19:41
@ricoberger ricoberger merged commit 819f428 into main Aug 17, 2022
@ricoberger ricoberger deleted the app-spike-implement-authentication branch August 17, 2022 20:04
@ricoberger ricoberger added the changelog: added A new feature was added label Sep 1, 2022
@ricoberger ricoberger changed the title [app] Implement Authentication [app] ⚠️ Breaking Change ⚠️ Implement Authentication Sep 1, 2022
@ricoberger ricoberger changed the title [app] ⚠️ Breaking Change ⚠️ Implement Authentication [app] ⚠️ Implement Authentication Sep 1, 2022
@ricoberger ricoberger changed the title [app] ⚠️ Implement Authentication ⚠️ [app] Implement Authentication Sep 2, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
changelog: added A new feature was added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants