Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[app] Fix 404 error for ACE worker files #410

Merged
merged 1 commit into from
Aug 6, 2022
Merged

Conversation

ricoberger
Copy link
Member

When a user opens a page with an Editor component a 404 error was thrown
in the console, because the worker files for ACE (the underlying editor)
could not be found. This is fixed by disabling workers using the
"useWorker: false" in the "setOptions" property.

This also disables syntax checking in ACE. If we want to use syntax
checking in the future, we can set "useWorker: true" and import the
"ace-builds/webpack-resolver" file.

When a user opens a page with an Editor component a 404 error was thrown
in the console, because the worker files for ACE (the underlying editor)
could not be found. This is fixed by disabling workers using the
"useWorker: false" in the "setOptions" property.

This also disables syntax checking in ACE. If we want to use syntax
checking in the future, we can set "useWorker: true" and import the
"ace-builds/webpack-resolver" file.
@codecov-commenter
Copy link

Codecov Report

Merging #410 (c372d32) into main (9eced52) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #410   +/-   ##
=======================================
  Coverage   47.29%   47.29%           
=======================================
  Files         138      138           
  Lines       11443    11443           
=======================================
  Hits         5412     5412           
  Misses       5892     5892           
  Partials      139      139           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ricoberger ricoberger merged commit 672d022 into main Aug 6, 2022
@ricoberger ricoberger deleted the app-fix-ace-404-error branch August 6, 2022 18:25
@ricoberger ricoberger added the changelog: fixed Something which wasn't working is fixed label Sep 1, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
changelog: fixed Something which wasn't working is fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants