Skip to content

[app] Show empty integer colums as 0 in CRs #436

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

ricoberger
Copy link
Member

When a CR is displayed in the resource table and a column of type integer is empty it didn't show anything. This is fixed now and a 0 is displayed for empty columns of type integer.

When a CR is displayed in the resource table and a column of type integer is empty it didn't show anything. This is fixed now and a 0 is displayed for empty columns of type integer.
@ricoberger ricoberger requested a review from monotek October 11, 2022 12:34
@codecov-commenter
Copy link

Codecov Report

Merging #436 (7d5819d) into main (26b44dc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #436   +/-   ##
=======================================
  Coverage   43.90%   43.90%           
=======================================
  Files         143      143           
  Lines       12358    12358           
=======================================
  Hits         5426     5426           
  Misses       6793     6793           
  Partials      139      139           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ricoberger ricoberger added the changelog: fixed Something which wasn't working is fixed label Oct 11, 2022
@ricoberger ricoberger merged commit df0e922 into main Oct 11, 2022
@ricoberger ricoberger deleted the app-show-empty-integer-values-as-0 branch October 11, 2022 12:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
changelog: fixed Something which wasn't working is fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants