Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Re-add Prometheus Plugin #77

Merged
merged 1 commit into from
Jul 3, 2021
Merged

Re-add Prometheus Plugin #77

merged 1 commit into from
Jul 3, 2021

Conversation

ricoberger
Copy link
Member

Re-add the Prometheus plugin as it already exists. We adjusted the
existing Prometheus plugin to fit in the new plugin system for kobs. For
that the code for the plugin lives now in the plugins folder.

The Prometheus plugin supports the same features as the former
implementation, but we are now using nivo to render the charts instead
of the Patternfly charting library. We decided to change the library,
because nivo can render canvas charts, which comes with a better
performance for the dashboards.

We also made some adjustments to the dashboards handling, so that we are
now only calculating the dimensions for the dashboards once instead of
for every dashboard. We also adjusted the tab handling, so that the
currently selected dashboard is reflected in the url. We plan to extend
this later, so that also the selected time range and variables are
reflected in the url.

Re-add the Prometheus plugin as it already exists. We adjusted the
existing Prometheus plugin to fit in the new plugin system for kobs. For
that the code for the plugin lives now in the plugins folder.

The Prometheus plugin supports the same features as the former
implementation, but we are now using nivo to render the charts instead
of the Patternfly charting library. We decided to change the library,
because nivo can render canvas charts, which comes with a better
performance for the dashboards.

We also made some adjustments to the dashboards handling, so that we are
now only calculating the dimensions for the dashboards once instead of
for every dashboard. We also adjusted the tab handling, so that the
currently selected dashboard is reflected in the url. We plan to extend
this later, so that also the selected time range and variables are
reflected in the url.
@ricoberger ricoberger merged commit 0ab891f into v0.4.0 Jul 3, 2021
@ricoberger ricoberger deleted the readd-prometheus-plugin branch July 3, 2021 22:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant