-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: fetch oda on drops page #11404
Conversation
Deploying koda-art-prod with
|
Latest commit: |
6625370
|
Status: | ✅ Deploy successful! |
Preview URL: | https://0670aa00.kodaart-production.pages.dev |
Branch Preview URL: | https://feat--fetch-oda-on-drops-pag.kodaart-production.pages.dev |
✅ Deploy Preview for polkadot ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
<CollectionDropCreatedBy :address="address" /> | ||
<CollectionDropCreatedBy | ||
:address="address" | ||
:show-popover="false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why change the popover?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to fix props required from CollectionDropCreatedBy
component
@@ -30,6 +30,7 @@ | |||
hide-listing | |||
show-timestamp | |||
:reset-search-query-params="['sort']" | |||
fetch-onchain-data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when the collection is generative art, could we add this fetch-onchain-data
to the collection details page, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, we can add to collection page also
if (isAssetHub.value && items.value.length && props.fetchOnchainData) { | ||
processOnchainData() | ||
} | ||
}, { immediate: true }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the new added items need to be fetched, or it will cause duplicating metadata fetch for the same nft item.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will check
oh, accidentally merged? |
Thank you for your contribution to the Koda - Generative Art Marketplace.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
Screenshot 📸