Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: fetch oda on drops page #11404

Merged
merged 3 commits into from
Feb 7, 2025
Merged

feat: fetch oda on drops page #11404

merged 3 commits into from
Feb 7, 2025

Conversation

preschian
Copy link
Member

@preschian preschian commented Feb 7, 2025

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
before after
Screenshot 2025-02-07 at 14 22 19 Screenshot 2025-02-07 at 14 22 21

Copy link

cloudflare-workers-and-pages bot commented Feb 7, 2025

Deploying koda-art-prod with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6625370
Status: ✅  Deploy successful!
Preview URL: https://0670aa00.kodaart-production.pages.dev
Branch Preview URL: https://feat--fetch-oda-on-drops-pag.kodaart-production.pages.dev

View logs

Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for polkadot ready!

Name Link
🔨 Latest commit 6625370
🔍 Latest deploy log https://app.netlify.com/sites/polkadot/deploys/67a5bf6f55b8420008cff595
😎 Deploy Preview https://deploy-preview-11404--polkadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 6625370
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/67a5bf704a96cc00087c43b5
😎 Deploy Preview https://deploy-preview-11404--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarqubecloud bot commented Feb 7, 2025

@preschian preschian marked this pull request as ready for review February 7, 2025 09:01
@preschian preschian requested a review from a team as a code owner February 7, 2025 09:01
@preschian preschian requested review from vikiival and Jarsen136 and removed request for a team February 7, 2025 09:01
@preschian
Copy link
Member Author

I've added this section, copied from TofuNFT. Any ideas what text we should put in this section? @kodadot/internal-dev

This will allow users to clear the cache if there are problems with NFT metadata (name/image-preview).

Screenshot 2025-02-07 at 15 56 24

@preschian preschian requested a review from hassnian February 7, 2025 09:01
<CollectionDropCreatedBy :address="address" />
<CollectionDropCreatedBy
:address="address"
:show-popover="false"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change the popover?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to fix props required from CollectionDropCreatedBy component

@@ -30,6 +30,7 @@
hide-listing
show-timestamp
:reset-search-query-params="['sort']"
fetch-onchain-data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when the collection is generative art, could we add this fetch-onchain-data to the collection details page, too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, we can add to collection page also

Comment on lines +324 to +327
if (isAssetHub.value && items.value.length && props.fetchOnchainData) {
processOnchainData()
}
}, { immediate: true })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the new added items need to be fetched, or it will cause duplicating metadata fetch for the same nft item.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will check

@vikiival vikiival merged commit 5514c43 into main Feb 7, 2025
26 checks passed
@vikiival vikiival deleted the feat--fetch-oda-on-drops-page branch February 7, 2025 10:04
@preschian
Copy link
Member Author

oh, accidentally merged?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

attractors: preview not loaded attractors: #229 wrong preview attractors: #228 - minted twice: Weird bug
3 participants