Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Monterey : borders have (internal) shadow #1056

Closed
rougier opened this issue Nov 19, 2021 · 7 comments
Closed

Monterey : borders have (internal) shadow #1056

rougier opened this issue Nov 19, 2021 · 7 comments

Comments

@rougier
Copy link

rougier commented Nov 19, 2021 •
edited
Loading

I know borders are not supposed to work (yet) with Monterey but they are kind of working for me. One problem though is that they somehow add an internal shadow over the window as shown on the screenshot. Left is with yabai off, right is with yabai on (I manually cropped the external drop shadow to better highlight the problem). I'm not asking for a fix, but maybe this information is important to help debug borders.

screenshot
@cxa
Copy link

cxa commented Nov 20, 2021

It's a known issue. If you want some workaround, just check my fork.

@rougier
Copy link
Author

rougier commented Nov 20, 2021

ok, thanks. Didn't noticed it before.

@rougier rougier closed this as completed Nov 20, 2021
@rougier rougier reopened this Nov 29, 2021
@rougier
Copy link
Author

rougier commented Nov 29, 2021

After searching, it seems the problem has been solved by this commit but it somehow re-appears in latest HEAD (or even before) on my machine. Can anyone confirm the behavior?

@cxa
Copy link

cxa commented Nov 30, 2021

I can confirm that this fix is not for Monterey, kCGSDisableShadowTagBit does not work anymore.

@rougier rougier changed the title Monterey : borders add "internal shadow" Monterey : borders have (internal) shadow Dec 1, 2021
@koekeishiya
Copy link
Owner

update to v4.0.0.

@rougier
Copy link
Author

rougier commented Mar 20, 2022

Shadow has been reduced but I think it is still here. Left is border by OSX (Increase contrast), right is yabai (HEAD):

screenshot

koekeishiya added a commit that referenced this issue May 17, 2022
@koekeishiya
#1056 remove shadow artifact from borders
4343787
@koekeishiya
Copy link
Owner

Fixed in v4.0.1.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cxa @rougier @koekeishiya