Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change window placement of warp command to be more natural #1435

Closed
koekeishiya opened this issue Sep 21, 2022 · 1 comment
Closed

Change window placement of warp command to be more natural #1435

koekeishiya opened this issue Sep 21, 2022 · 1 comment
Labels
suggestion Request for new feature or some form of enhancement

Comments

@koekeishiya
Copy link
Owner

When a window is warped in a cardinal direction it should set the window placement (first_child, second_child) according to the direction it came from, to make the movement more natural.

Current behaviour:

+---------+               +---------+                                         
|    |    |               |    |    |                                       
|    |  b |   warp west   | a  |    |                                     
| a  |----|   b  -->  a   |----|  c |                                    
|    |  c |               | b  |    |                              
|    |    |               |    |    |                                  
+---------+               +---------+                               

The more natural result would be:

+---------+               +---------+                                         
|    |    |               |    |    |                                       
|    |  b |   warp west   | b  |    |                                     
| a  |----|   b  -->  a   |----|  c |                                    
|    |  c |               | a  |    |                              
|    |    |               |    |    |                                  
+---------+               +---------+                               

Same thing here:

+---------+               +---------+                                         
|         |               |    |    |                                       
|    a    |   warp north  | a  |  b |                                     
|----|----|   b  -->  a   |----|----|                                    
| b  |  c |               |    c    |                              
|    |    |               |         |                                  
+---------+               +---------+                               

The more natural result would be:

+---------+               +---------+                                         
|         |               |    |    |                                       
|    a    |   warp north  | b  |  a |                                     
|----|----|   b  -->  a   |----|----|                                    
| b  |  c |               |    c    |                              
|    |    |               |         |                                  
+---------+               +---------+                               
@koekeishiya koekeishiya added the suggestion Request for new feature or some form of enhancement label Sep 21, 2022
@FelixKratz
Copy link

I have decided to implement this: https://github.com/FelixKratz/yabai/commit/c7ae69a3ed40a23fdd8e74ccf6a19b87974816b1
It feels very nice

koekeishiya added a commit that referenced this issue Dec 12, 2022
@koekeishiya koekeishiya added addressed on master; not released Fixed upstream, but not yet released and removed addressed on master; not released Fixed upstream, but not yet released labels Dec 12, 2022
koekeishiya added a commit that referenced this issue Dec 17, 2022
shinyquagsire23 pushed a commit to shinyquagsire23/yabai that referenced this issue Jun 7, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
suggestion Request for new feature or some form of enhancement
Projects
None yet
Development

No branches or pull requests

2 participants