Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

attempt to detect child windows #2044

Closed
koekeishiya opened this issue Jan 7, 2024 · 0 comments
Closed

attempt to detect child windows #2044

koekeishiya opened this issue Jan 7, 2024 · 0 comments
Labels
suggestion Request for new feature or some form of enhancement

Comments

@koekeishiya
Copy link
Owner

koekeishiya commented Jan 7, 2024

Some changes were recently introduced in #2036 that makes yabai not detect and track windows that do not report as what is defined as a "real window". After some testing I feel like this alone is not the correct approach.

--

Firstly we should detect whether or not the created window is a "root window" or a "child/sub window". Only windows that report as a "root window" will be eligible target for window rules, tiling, and focus follows mouse. Windows that do not identify as a "root window" will be tracked, but they will not be targeted by window rules and they will never be tiled (not even through force) or focused through focus follows mouse.

This catches some windows, but not all of them, because e.g some "Settings/Preferences Dialogs" etc. identify as a "root window". This is where the second part (already implemented in #2036) kicks in; only windows that match the "AXRole" and "AXSubrole" of a "real window" will be tiled, all other types will be treated as floating. All of these windows are eligible targets for window rules, and in this part it might be necessary for the user to step in correct the behaviour for some applications/windows.

Additionally, rules that set manage=on without specifying AXRole and AXSubrole filter, will now only apply to windows that have AXRole=AXWindow and AXSubrole=AXStandardWindow.

The root-window property is also added as an attribute returned in window queries.

@koekeishiya koekeishiya added the suggestion Request for new feature or some form of enhancement label Jan 7, 2024
koekeishiya added a commit that referenced this issue Jan 7, 2024
koekeishiya added a commit that referenced this issue Jan 8, 2024
koekeishiya added a commit that referenced this issue Jan 8, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
suggestion Request for new feature or some form of enhancement
Projects
None yet
Development

No branches or pull requests

1 participant