-
-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Suggestion] Change the way of loading yabairc to execute yabairc file #2169
Comments
If you think this suggestion is stupid, or hard to do, please let me know, especially why. |
Note that this specific part of the code has been untouched since like v1.0.0 from 5years ago, prior to #1993. |
After spending more than 5 seconds it is obviously clear why the change suggested in #1993 would change this behavior. If you belong to a third group that require other behavior; feel free to go buy ice cream. |
Thank you very much! Feel free to close this issue, or if you plan to do it after release. |
TL;DL:
Loading yabairc by executing yabairc file can support more flexible script, at least fork the process using
bash
instead ofsh
.Full Details:
I found some issue when I use the following configuration in my
~/.yabairc
:And I get output:
Obviously, the interpreter/the process is not
bash
, or the one specified by the Shebang. And I confirmed this by issue #1993. As #1993 clarifys, the proccess issh
, and I confirmed this by some code likeecho "Current Process Name: $(ps -p $$ -o comm=)"
.I'm not sure if the failure of yabai injecting payload is caused by
sh
, but I get nothing wrong by execute them manually in a bash/zsh.I'm not a good programmer. I tried to contribute to the source code but failed. So what I can only do is just raising an issue for suggestion.
The text was updated successfully, but these errors were encountered: