Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Detached firefox tab gets moved to wrong space #951

Closed
s00500 opened this issue Jul 4, 2021 · 4 comments
Closed

Detached firefox tab gets moved to wrong space #951

s00500 opened this issue Jul 4, 2021 · 4 comments
Labels
suggestion Request for new feature or some form of enhancement

Comments

@s00500
Copy link

s00500 commented Jul 4, 2021

Hey everyone, I got a strange problem:
I am running firefox on one display and have an empty space on a second display. If I create a new tab in firefox, then take the tab and move it to the next space it would usually (without yabai running) expand to a fullscreen window on the second display. With yabai running though it clearly gets created on the second display and then yabai moves it back to the main focused display. I also tried to query all windows on the window_created event and I can see that yabai does not get that the window got created on the second display, but thinks it got created on the main display. Interestingly it still shows a window_moved event afterwards...

I believe a fix of this could be done in config, but I feel I am missing a good approach... generally the wrong detection feels like either a strange firefox behaviour or a bug in yabai...

Thanks,
Lukas

@koekeishiya
Copy link
Owner

koekeishiya commented Aug 13, 2021 via email

@s00500
Copy link
Author

s00500 commented Aug 13, 2021

Hi @koekeishiya,
Thank you for the detailed explanation!!!
For me it is kind of annoying as it causes another operation with the mouse I did want to avoid....

If there is anything I can do to help you test this I am up for it, I guess a cool way to handle it would be a way to override this behavior using the rule engine... this way we could test if it makes the UX better for apps like firefox

Yabai has been a really awesome addition to my workflow so far, and this is one of the details I still would like to polish
Let me know what I can do to help here 😃

Greetings,
Lukas

@koekeishiya
Copy link
Owner

koekeishiya commented Aug 13, 2021 via email

koekeishiya added a commit that referenced this issue Aug 14, 2021
@koekeishiya koekeishiya added suggestion Request for new feature or some form of enhancement the-future I never think of the future - it comes soon enough. labels Aug 14, 2021
@s00500
Copy link
Author

s00500 commented Aug 17, 2021

Hi @koekeishiya,
I just compiled and tested the the-future branch and set the config to "cursor"
This causes the exact behavior I was looking for, really nice!!!
As of right now I am on holiday and only use 1 monitor most of the time, (just tested with the TV to check the patch), so I can not say for sure yet if this could cause other unwanted side effects, but I think it should work well, also because this is no default option, so it wont break stuff for now...

I will continue looking out for potential hickups when I get back to my normal 3-display worksetup next week and update this issue if anything comes up

Thanks a lot for addressing the issue!!!

@koekeishiya koekeishiya added the addressed on master; not released Fixed upstream, but not yet released label Nov 18, 2021
@koekeishiya koekeishiya removed addressed on master; not released Fixed upstream, but not yet released the-future I never think of the future - it comes soon enough. labels Mar 16, 2022
Amar1729 added a commit to Amar1729/yabai-zsh-completions that referenced this issue May 26, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
suggestion Request for new feature or some form of enhancement
Projects
None yet
Development

No branches or pull requests

2 participants