Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

More helpful metadata #77

Merged
merged 2 commits into from
Jan 21, 2023
Merged

Conversation

space-nuko
Copy link
Contributor

Some more metadata that could be useful to have later:

  • Dataset/reg image dirs - the number of images in each directory, the name of each directory and the repeat count
  • random session ID - uniquely identifies a set of models as belonging to the same training session
  • keep tokens - another command line argument
  • training date - date that the set this model came from was trained on, useful for historical purposes
  • output name - the output name passed to the script

Let me know if there's more that could be useful

- dataset/reg image dirs
- random session ID
- keep_tokens
- training date
- output name
@kohya-ss
Copy link
Owner

Thank you for PR! It looks good!

I would like to add a feature to LoRA module to extend the support to Conv2d with 3x3 filter. It is possible to know if Conv2d is supported by the model, by the weights in safetensors/ckpt file, but I would like to have the version in the metadata as well.
(like "1.0.0" or "2.0.0" as semantic versioning, or simply "linear" and "conv2d".)

Therefore, I will merge this as soon as I finish adding that feature. If it takes too long, I'll merge this first.

@kohya-ss kohya-ss changed the base branch from main to dev January 21, 2023 03:11
@kohya-ss kohya-ss merged commit 7dbcef7 into kohya-ss:dev Jan 21, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants