Skip to content

Commit

Permalink
restore min sdk version to 14. important for accessibility requires m…
Browse files Browse the repository at this point in the history
…in sdk of 16 but setting the content description instead is ok on 14. Talkback should now announce the divider as "country preference divier" instead of just saying "unlabeled"
  • Loading branch information
davidmcdermott2 committed Dec 21, 2021
1 parent 2206d53 commit 95cde86
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion countrycodepicker/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ android {
buildToolsVersion "29.0.3"

defaultConfig {
minSdkVersion 16
minSdkVersion 14
targetSdkVersion 29
versionCode verCode
versionName version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
>

<ImageView
android:contentDescription="@null"
android:id="@+id/flag_imv"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
Expand Down Expand Up @@ -55,7 +56,7 @@
/>

<View
android:importantForAccessibility="no"
android:contentDescription="@string/country_preference_divider"
android:id="@+id/preference_divider_view"
android:layout_width="match_parent"
android:layout_height="2dp"
Expand Down
1 change: 1 addition & 0 deletions countrycodepicker/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@
<string name="country_full_name_and_name_code" translatable="false">%1$s (%2$s)</string>
<string name="country_full_name_name_code_and_phone_code" translatable="false">%1$s (%2$s) +%3$s</string>
<string name="error_unregister_carrier_number" translatable="false">EditText for carrier number is not registered. Register it using registerPhoneNumberTextView() before getFullNumber() or setFullNumber().</string>
<string name="country_preference_divider" translatable="false">country preference divider</string>
</resources>
2 changes: 2 additions & 0 deletions sampletv/src/main/res/layout/activity_main.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
app:ccp_hidePhoneCode="false"
app:ccp_keyboardAutoPopOnSearch="false"
app:ccp_showFullName="false"
app:ccp_countryPreference="US"
app:ccp_defaultNameCode="US"
/>

</RelativeLayout>

0 comments on commit 95cde86

Please # to comment.