The index image generation was being skipped #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arewm
force-pushed
the
get-multiarch-building
branch
3 times, most recently
from
7db0f80 to
733bc49
Compare
arewm
changed the title
Since the `build-image-index` depends on the results from each of the architecture-specific builds, the task (and all resulting dependant tasks) will be skipped if any of these are absent. Using the intended workflow of enabling users to specify the architectures to run with PipelineRun params will require this model to change. The PR konflux-ci/build-definitions#1111 is a potentially promising way to resolve this issue. Signed-off-by: arewm <arewm@users.noreply.github.com>
Signed-off-by: arewm <arewm@users.noreply.github.com>
arewm
force-pushed
the
get-multiarch-building
branch
from
733bc49 to
01ec295
Compare
arewm
added a commit
to arewm/olm-operator-konflux-sample
that referenced
this pull request
Jul 17, 2024
During the development of the bundle image reworking, it was noticed that the multi-arch images were not actually properly being generated. This was fixed in konflux-ci#15 before the bundle could be properly built. Signed-off-by: arewm <arewm@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
build-image-indexdepends on the results from each of thearchitecture-specific builds, the task (and all resulting dependant
tasks) will be skipped if any of these are absent.
Using the intended workflow of enabling users to specify the
architectures to run with PipelineRun params will require this model to
change. The PR konflux-ci/build-definitions#1111
is a potentially promising way to resolve this issue.