Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Updating path for kubeconfig #857

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

konstructcarrie
Copy link
Contributor

Description

Updating path to correct path for export for Kubeconfig

Related Issue(s)

#854

How to test

Verify changes appear where expected

@mrsimonemms mrsimonemms self-requested a review January 7, 2025 14:47
Copy link
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking, the path is ~/.k1/<cluster-name>/kubeconfig. I think it's ok to use ~/.k1/kubefirst/kubeconfig because we only ever use kubefirst as the cluster name in the docs, but might need an explanatory note.

@konstructcarrie
Copy link
Contributor Author

Strictly speaking, the path is ~/.k1/<cluster-name>/kubeconfig. I think it's ok to use ~/.k1/kubefirst/kubeconfig because we only ever use kubefirst as the cluster name in the docs, but might need an explanatory note.

What's the scenario where a user might see a different path? For example if I were to write a note I'd say something like.

This path can also be ~/.k1/<cluster-name>/kubeconfig if you've modified the cluster name during x,y.z, or in such and such file.

@mrsimonemms
Copy link
Contributor

@konstructcarrie the path will be whatever the given cluster-name is. By default, it's kubefirst but the CLI has a --cluster-name flag that can be provided (the Marketplace/UI installers also allow it to be configured).

My suggestion would be to use ~/.k1/kubefirst/kubeconfig as you have done and add an explanatory note. I also think one could justify not adding the note for the sake of clarity. My suggested note would be:

The default name for the management cluster is kubefirst. If you change the cluster name, the path will be updated to ~/.k1/<cluster-name>/kubeconfig.

@konstructcarrie
Copy link
Contributor Author

@johndietz Circling back to this, where did we land on how we wanted to address this. I've lost track.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants