✨ Run from /addon so we can run as non-root user #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Montleon <jmontleo@redhat.com>
jortel
reviewed
Oct 9, 2024
| WORKDIR /addon |
There was a problem hiding this comment.
Would /tmp be a better (more agnostic) default?
There was a problem hiding this comment.
@shawn-hurley @pranavgaikwad @fabianvf any opinions? /tmp sound good to me, but you all know far more about this project than I do.
There was a problem hiding this comment.
I think that /addon is good IMO
dymurray
added
the
cherry-pick/release-0.5
dymurray
approved these changes
Oct 10, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 10, 2024
Signed-off-by: Jason Montleon <jmontleo@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com>
jmle
pushed a commit
to jmle/analyzer-lsp
that referenced
this pull request
Oct 25, 2024
Signed-off-by: Jason Montleon <jmontleo@redhat.com>
This was referenced Nov 21, 2024
This was referenced Jan 10, 2025
This was referenced Jan 23, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.