🐛 Fix task group update. #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Ortel <jortel@redhat.com>
jortel
commented
Jun 6, 2024
| }) | ||
| return | ||
| } | ||
| } |
There was a problem hiding this comment.
hint: Since the update of a Ready task effectively submits it which creates all of the tasks, this check ensure the tasks are not created more than once.
Signed-off-by: Jeff Ortel <jortel@redhat.com>
jortel
commented
Jun 6, 2024
| @@ -221,17 +230,16 @@ func (h TaskGroupHandler) Update(ctx *gin.Context) { | |||
| for i := range m.Tasks { | |||
| task := &tasking.Task{} | |||
| task.With(&m.Tasks[i]) | |||
| err = rtx.TaskManager.Update(h.DB(ctx), task) | |||
| err = rtx.TaskManager.Create(h.DB(ctx), task) | |||
There was a problem hiding this comment.
hint: main fix. should be creating the tasks, not updating them.
jortel
commented
Jun 6, 2024
| @@ -172,7 +173,7 @@ func (m *Manager) Update(db *gorm.DB, requested *Task) (err error) { | |||
| if err != nil { | |||
| return | |||
| } | |||
| switch requested.State { | |||
| switch task.State { | |||
There was a problem hiding this comment.
hint: conditional logic should be based on fetched task.
mansam
approved these changes
Jun 6, 2024
This was referenced Jun 22, 2024
This was referenced Jul 30, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix task group submit.
Update to follow error reporting pattern.