Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

✨ Broker KAI api through hub. #750

Merged
merged 11 commits into from
Sep 13, 2024
Merged

✨ Broker KAI api through hub. #750

merged 11 commits into from
Sep 13, 2024

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Sep 10, 2024

Add /services/ endpoint.
Add /services/kai/* endpoint reverse-proxy to route defined in KAI_URL.
Add auth scopes.

Related: konveyor/operator#376

sjd78 pushed a commit to konveyor/tackle2-ui that referenced this pull request Sep 12, 2024
Related: konveyor/tackle2-hub#750

Signed-off-by: Jeff Ortel <jortel@redhat.com>
sjd78 pushed a commit to sjd78/tackle2-ui that referenced this pull request Sep 12, 2024
Related: konveyor/tackle2-hub#750

Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
@jortel
Copy link
Contributor Author

jortel commented Sep 12, 2024

Tested with auth enabled.

Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please correct me if I'm wrong, in "standard" k8s-based Konveyor installation, there are two proxies to access the kai (UI->Hub, Hub->kai) while Hub cares about authorization. The main reason for that is to be able re-use kai service with inside-IDE instalations?

@jortel
Copy link
Contributor Author

jortel commented Sep 13, 2024

LGTM

Please correct me if I'm wrong, in "standard" k8s-based Konveyor installation, there are two proxies to access the kai (UI->Hub, Hub->kai) while Hub cares about authorization. The main reason for that is to be able re-use kai service with inside-IDE instalations?

Exactly. The only purpose of proxying through the hub is to enforce AUTH.

@jortel jortel merged commit 7477257 into konveyor:main Sep 13, 2024
14 checks passed
Shevijacobson pushed a commit to Shevijacobson/tackle2-ui that referenced this pull request Sep 18, 2024
Related: konveyor/tackle2-hub#750

Signed-off-by: Jeff Ortel <jortel@redhat.com>
Shevijacobson pushed a commit to Shevijacobson/tackle2-ui that referenced this pull request Sep 18, 2024
Related: konveyor/tackle2-hub#750

Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Shevijacobson <shevijacob@gmail.com>
DvoraShechter1 pushed a commit to DvoraShechter1/tackle2-ui that referenced this pull request Sep 19, 2024
Related: konveyor/tackle2-hub#750

Signed-off-by: Jeff Ortel <jortel@redhat.com>
dymurray pushed a commit that referenced this pull request Oct 11, 2024
Add `/services/` endpoint.
Add `/services/kai/*` endpoint reverse-proxy to route defined in
KAI_URL.
Add auth scopes.

Related: konveyor/operator#376

---------

Signed-off-by: Jeff Ortel <jortel@redhat.com>
DvoraShechter1 pushed a commit to DvoraShechter1/tackle2-ui that referenced this pull request Oct 28, 2024
Related: konveyor/tackle2-hub#750

Signed-off-by: Jeff Ortel <jortel@redhat.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants