✨ Update stakeholders table to use ActionsColumn

[mguetta1]

Part of #1318

UI Tests PR: 1201

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.15%. Comparing base (b654645) to head (2d4b5c8).
Report is 227 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1923      +/-   ##
==========================================
+ Coverage   39.20%   42.15%   +2.95%     
==========================================
  Files         146      174      +28     
  Lines        4857     5577     +720     
  Branches     1164     1376     +212     
==========================================
+ Hits         1904     2351     +447     
- Misses       2939     3210     +271     
- Partials       14       16       +2     

Flag	Coverage Δ
client	42.15% <ø> (+2.95%)	⬆️
server	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sjd78]

Part of #1318?

[sjd78]

Looks like a good change. @mguetta1 any reason it is still in draft?

[mguetta1]

Part of #1318?

Yes

[mguetta1]

Looks like a good change. @mguetta1 any reason it is still in draft?

I need to change this to use https://github.com/konveyor/tackle2-ui/blob/main/client/src/app/pages/controls/ControlTableActionButtons.tsx

[sjd78]

LGTM

[sjd78]

@mguetta1 The PR change is causing e2e-ui-test fails:

• https://github.com/konveyor/tackle2-ui/actions/runs/10710591872/job/29700435669#step:12:1176
• https://github.com/konveyor/tackle2-ui/actions/runs/10710591872/job/29700435669#step:12:2307

The test is probably looking for a kebab menu action that doesn't exists or got moved to the edit pencil.

[mguetta1]

@mguetta1 The PR change is causing e2e-ui-test fails:

• https://github.com/konveyor/tackle2-ui/actions/runs/10710591872/job/29700435669#step:12:1176
• https://github.com/konveyor/tackle2-ui/actions/runs/10710591872/job/29700435669#step:12:2307

The test is probably looking for a kebab menu action that doesn't exists or got moved to the edit pencil.

Correct, here is the related PR in tackle-ui-tests: konveyor/tackle-ui-tests#1201
Please coordinate with @sshveta to merge the changes

[sjd78]

Correct, here is the related PR in tackle-ui-tests: konveyor/tackle-ui-tests#1201 Please coordinate with @sshveta to merge the changes

We can tell CI to use that PR in the e2e testing: https://github.com/konveyor/ci?tab=readme-ov-file#referencing-specific-pull-requests-in-the-test-repositories

[sjd78]

Note: Closed and reopened the PR to force all the check to run again with the update to the PR description to use a UI tests PR for e2e-ui testing.

[sjd78]

@mguetta1 - One more UI test fix needed for: https://github.com/konveyor/tackle2-ui/actions/runs/10722793005/job/29734751734?pr=1923#step:12:1174

Looks like a migration wave test that is setting up stakeholders first.

[mguetta1]

@mguetta1 - One more UI test fix needed for: https://github.com/konveyor/tackle2-ui/actions/runs/10722793005/job/29734751734?pr=1923#step:12:1174

Looks like a migration wave test that is setting up stakeholders first.

Thanks @sjd78. A fix was added.