Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

✨ Provide initial state for column management #1964

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

rszwajko
Copy link
Collaborator

@rszwajko rszwajko commented Jun 17, 2024

Related improvements:

  1. support restoring columns to initial configuration
  2. clean up invalid columns stored in local storage

Part-of: #1931

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 13.33333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 42.05%. Comparing base (b654645) to head (d39d7b3).
Report is 164 commits behind head on main.

Files Patch % Lines
.../app/hooks/table-controls/column/useColumnState.ts 14.28% 12 Missing ⚠️
...c/app/hooks/table-controls/useTableControlState.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1964      +/-   ##
==========================================
+ Coverage   39.20%   42.05%   +2.85%     
==========================================
  Files         146      166      +20     
  Lines        4857     5340     +483     
  Branches     1164     1337     +173     
==========================================
+ Hits         1904     2246     +342     
- Misses       2939     3078     +139     
- Partials       14       16       +2     
Flag Coverage Δ
client 42.05% <13.33%> (+2.85%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Related improvements:
1. support restoring columns to initial configuration
2. clean up invalid columns stored in local storage

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
@rszwajko rszwajko marked this pull request as ready for review June 17, 2024 19:56
Copy link
Member

@ibolton336 ibolton336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants