f/2840 add durable download linlk #45
Conversation
sansth1010
requested review from
rgwozdz,
sonofflynn89,
ethanspiro and
velveetachef
| @@ -79,10 +79,13 @@ export function enrichDataset(dataset: HubDataset, hubsite: HubSite): Feature { | |||
|
|
|||
| if (isLayer(dataset)) { | |||
| additionalFields.accessUrlGeoJSON = downloadLinkFor('geojson'); | |||
| additionalFields.durableUrlGeoJSON = generateDurableDownloadUrl(dataset.id, siteUrl, 'geojson'); | |||
There was a problem hiding this comment.
Wait, do we want to even keep the old links then if we are planning on introducing these durable ones?
There was a problem hiding this comment.
For now yes. Durable links will stay experimental until we finalize the new download service which hasn't been released to production yet and these durable links will only be used for testing hub feeds on DEV and QA as required by the issue 2840. Production hub feeds will be using old links for now.
Once, download service gets released to production, these old links will be removed from the provider.
| @@ -70,7 +70,10 @@ describe('enrichDataset function', () => { | |||
| provenance: '', | |||
| hubLandingPage: 'https://arcgis.com/maps/CALFIRE::DCAT_Test', | |||
| downloadLink: 'https://arcgis.com/datasets/CALFIRE::DCAT_Test', | |||
| agoLandingPage: 'portal.arcgis.com/home/item.html?id=0&sublayer=0', | |||
| durableUrlCSV: 'https://arcgis.com/api/download/v1/item/123a/csv?layers=0', | |||
There was a problem hiding this comment.
I totally get that you were just copying what existed, but I got really tripped up by the fact that these urls use arcgis.com instead of hub.arcgis.com (or my-hub-site.com, etc.). This is mainly because the download APIs are provided by us, not ArcGIS Online. Would you mind updating for consistency?
This PR adds durable download link for different file types ('CSV', 'GeoJSON', 'Shapefile')
Related: https://devtopia.esri.com/dc/hub/issues/2840