Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

implement bincode for tensor #209

Merged
merged 2 commits into from
Jan 1, 2025
Merged

implement bincode for tensor #209

merged 2 commits into from
Jan 1, 2025

Conversation

edgarriba
Copy link
Member

@edgarriba edgarriba commented Jan 1, 2025

This pull request introduces several changes to add support for bincode serialization and deserialization to the kornia-tensor crate. The changes include updates to dependencies, new module implementations, and additional test cases.

Dependency updates:

  • Added bincode as a dependency in Cargo.toml and made serde and bincode optional dependencies in crates/kornia-tensor/Cargo.toml. [1] [2]

Serialization and deserialization implementation:

  • Implemented bincode serialization and deserialization for the Tensor struct in crates/kornia-tensor/src/bincode.rs.
  • Added bincode module to crates/kornia-tensor/src/lib.rs.

Testing:

  • Added test cases for bincode serialization and deserialization in crates/kornia-tensor/src/bincode.rs.
  • Added test cases for serde serialization and deserialization in crates/kornia-tensor/src/serde.rs.

Build and test scripts:

  • Added a new test-all recipe to the justfile to test the code with all features enabled.

@edgarriba edgarriba merged commit 25edcbd into main Jan 1, 2025
12 checks passed
@edgarriba edgarriba deleted the tensor-bicode branch January 2, 2025 06:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant