Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

framework/element: Add className property handling #35

Closed
OleksiyRudenko opened this issue May 16, 2021 · 6 comments
Closed

framework/element: Add className property handling #35

OleksiyRudenko opened this issue May 16, 2021 · 6 comments
Assignees
@OleksiyRudenko
Labels
bug Something isn't working

Comments

@OleksiyRudenko
Copy link
Member

Problem:
createElement doesn't handle tags' className attribute.

Solution:
If className is a string then => split at spaces.
Then element.classList.add(...classNamesList)
@OleksiyRudenko OleksiyRudenko added the bug Something isn't working label May 16, 2021
@OleksiyRudenko OleksiyRudenko mentioned this issue May 17, 2021
Open
@OleksiyRudenko OleksiyRudenko self-assigned this May 18, 2021
@mustbefail
Copy link

is this task already taken? wanted to work on it

@OleksiyRudenko
Copy link
Member Author

@mustbefail sorry, taken. Wanted this and adjacent issues to be closed by tomorrow's AMA

@mustbefail
Copy link

ok, np

@mustbefail
Copy link

is there a task that I can join?

OleksiyRudenko pushed a commit that referenced this issue May 18, 2021
framework/element: add support of className property
13576f7 
Resolves #35
@OleksiyRudenko
Copy link
Member Author

@mustbefail sorry, not at the moment. Will keep the classroom posted of new tasks if there gonna be any

@OleksiyRudenko
Copy link
Member Author

Resolved by 13576f7

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@OleksiyRudenko OleksiyRudenko

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OleksiyRudenko @mustbefail