HTML-CSS-practice-popup_task

[Halv27]

HTML-CSS-practice-popup_task

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

[github-actions]

Hey!

Congratulations with your PR! 😎😎😎

Please, be sure you haven't followed common mistakes.

Also, be aware, that if you would silently ignore this recommendation, a mentor may think that you are still working on fixes. And your PR will not be reviewed. 😒

[Halv27]

Hey!

Congratulations with your PR! 😎😎😎

Please, be sure you haven't followed common mistakes.

Also, be aware, that if you would silently ignore this recommendation, a mentor may think that you are still working on fixes. And your PR will not be reviewed. 😒

Hi)) I checked the code, there are no typical mistakes in it.

[yaripey]

Hey, nice work! Let's improve it!

First of all, your popup button doesn't have any visual response for focusing it with the keyboard.

Secondly, you cannot get to the More button with the keyboard, focus just jumps from the Documents button to the Bell icon in the top bar.

About SVGs - your way of storing them inside the file is cool, but there could be some pros and cons to that. What's bad is that it messes up with file readability a little and those icons cannot be cached to improve performance. On the other hand, if you store them separately they might be lost somewhere since it creates more HTML requests, so you have to consider different perspectives when working with SVG when you get to real work. The common usage is to store all SVGs in one sprite and to use use. (pun intended)

You can leave SVGs unchanged here, it's fine for the first work.

[Halv27]

Hey, nice work! Let's improve it!

First of all, your popup button doesn't have any visual response for focusing it with the keyboard.

Secondly, you cannot get to the More button with the keyboard, focus just jumps from the Documents button to the Bell icon in the top bar.

About SVGs - your way of storing them inside the file is cool, but there could be some pros and cons to that. What's bad is that it messes up with file readability a little and those icons cannot be cached to improve performance. On the other hand, if you store them separately they might be lost somewhere since it creates more HTML requests, so you have to consider different perspectives when working with SVG when you get to real work. The common usage is to store all SVGs in one sprite and to use use. (pun intended)

You can leave SVGs unchanged here, it's fine for the first work.

Нi, thank you very much for the review.
I made some changes to make the focus work.
I didn't know about SVSs. Thank you for your response and the article, it was very useful and interesting information. But I didn't change anything this time.

[yaripey]

Good job!

[Halv27]

Good job!

Thanks))