task tiny js world

[DaniaB24]

tiny-js-world

Demo |
Code base

Please, review.

[OleksiyRudenko]

This is an agreed resubmission of kottans/frontend-2019-p2p#196 (one of three listed in #174 ).

@DaniaB24 please fix the code following the code as per DoD therein.

Also fix empty line addition in your code editor once for all.

You may find this helpful.

[github-actions]

Thank you for contributing to this repo! ❤️️

A Tiny JS World -- (pre-OOP) exercise check list

Let's do some self-checks to fix most common issues and to make some improvements to the code while reviewers find some time to dedicate it to your submission.

Go through the checklist below, fix code as appropriate and mark fulfilled requirements when you genuinely believe you are done.

Please, feel free to ask questions here or seek for help in the Students' chat.

Check-list - definition of done

• Code is DRY, which means that whenever you see a pattern in your code those should be eliminated as much as possible. Examples:
  • print(dog); print(cat); etc ... should be refactored employing Array.forEach as the least
  • `${obj.legs}; ${obj.name}; etc...` (yes, strings are also code) must be refactored employing appropriate Array methods
• Properties used to form an object presentation string must be explicitly listed/specified
• Object methods like keys, values, entries shouldn't be used as these do not guarantee any particular order of keys/values

Sincerely yours,
Submissions Kottachecker 😺

[OleksiyRudenko]

Please carefully check the comments above

[DaniaB24]

Please carefully check the comments above

thank you a lot for the review! My bad, sorry:(
the problem is in the code link

[DaniaB24]

Please carefully check the comments above

thank you a lot for the review! My bad, sorry:( the problem is in the code link

this link led to pre-oop code

[OleksiyRudenko]

Please see the comment below.

[OleksiyRudenko]

(1) Double-check the tem one of the checklist above (re DRY code).
Ask questions if anything is not clear - here or on Students' chat.

(2) Please tune your IDE to add an empty line at the end of files.

[DaniaB24]

its also pre-oop code , sorry:( I will change the link to the code

[OleksiyRudenko]

Ping me when you double-check everything.
I'd expect to read something like "Listed requirements are met, questions I had are asked, code is updated accordingly, links are updated".

[DaniaB24]

I think links are updated @OleksiyRudenko

Ping me when you double-check everything. I'd expect to read something like "Listed requirements are met, questions I had are asked, code is updated accordingly, links are updated".

[OleksiyRudenko]

I still can see that there is no new line at the end of file:

Also there is a requirement which says:

• Code is DRY, which means that whenever you see a pattern in your code those should be eliminated as much as possible. Examples:
  • print(dog); print(cat); etc ... should be refactored employing Array.forEach as the least
  • `${obj.legs}; ${obj.name}; etc...` (yes, strings are also code) must be refactored employing appropriate Array methods

Feel free asking questions.

[DaniaB24]

I still can see that there is no new line at the end of file:

Also there is a requirement which says:

• Code is DRY, which means that whenever you see a pattern in your code those should be eliminated as much as possible. Examples:

  • print(dog); print(cat); etc ... should be refactored employing Array.forEach as the least
  • `${obj.legs}; ${obj.name}; etc...` (yes, strings are also code) must be refactored employing appropriate Array methods

Feel free asking questions.

I honestly do not know why this happens, I will try to fix it tomorrow

[DaniaB24]

I still can see that there is no new line at the end of file:

Also there is a requirement which says:

• Code is DRY, which means that whenever you see a pattern in your code those should be eliminated as much as possible. Examples:

  • print(dog); print(cat); etc ... should be refactored employing Array.forEach as the least
  • `${obj.legs}; ${obj.name}; etc...` (yes, strings are also code) must be refactored employing appropriate Array methods

Feel free asking questions.

I think I did it))) review pls @OleksiyRudenko

[DaniaB24]

@OleksiyRudenko

[OleksiyRudenko]

@DaniaB24 great job done!