Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

hooliPopup first commit #261

Merged
merged 17 commits into from
Aug 29, 2022
Merged

hooliPopup first commit #261

merged 17 commits into from
Aug 29, 2022

Conversation

YuraZagor
Copy link
Contributor

task name

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

@github-actions
Copy link

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure you haven't made common mistakes.

Universal recommendations:

  • Give variables and functions meaningful names. Avoid generic names like item, element, key, object, array or their variations. Exception: helper functions that are specifically and intentionally designed to be multipurpose.
  • Function names should start with a verb as they denote actions; variables are normally nouns; boolean variables/functions start with is, does, has etc; variable containing multiple entities and functions returning lists contain entity name in plural form.
  • Have consistent code style and formatting. Employ Prettier to do all dirty work for you.
  • Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

Also take a note of the requirements above and follow them in all your future projects.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

Copy link
Contributor

@expero1 expero1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. You must add only index.html and style.css files in pull request for this task.

@YuraZagor YuraZagor marked this pull request as draft August 26, 2022 11:34
@A-Ostrovnyy
Copy link
Collaborator

Is this PR ready for review? If yes please change the status from Draft to Ready for review.

@YuraZagor YuraZagor marked this pull request as ready for review August 27, 2022 11:31
@YuraZagor YuraZagor requested a review from expero1 August 27, 2022 11:45
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

submissions/YuraZagor/hooliPopup/index.html Outdated Show resolved Hide resolved
submissions/YuraZagor/hooliPopup/index.html Outdated Show resolved Hide resolved
submissions/YuraZagor/hooliPopup/index.html Outdated Show resolved Hide resolved
submissions/YuraZagor/hooliPopup/index.html Outdated Show resolved Hide resolved
submissions/YuraZagor/hooliPopup/index.html Outdated Show resolved Hide resolved
submissions/YuraZagor/hooliPopup/style.css Outdated Show resolved Hide resolved
submissions/YuraZagor/hooliPopup/style.css Outdated Show resolved Hide resolved
submissions/YuraZagor/hooliPopup/style.css Outdated Show resolved Hide resolved
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress!

@A-Ostrovnyy A-Ostrovnyy self-assigned this Aug 29, 2022
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@A-Ostrovnyy A-Ostrovnyy merged commit 6639a84 into kottans:main Aug 29, 2022
SphericalCat pushed a commit to SphericalCat/frontend-2022-homeworks that referenced this pull request Aug 30, 2022
* hooliPopup first commit

* added a-hrefs to animate popup

* Deleted tabindexes and  a-hrefs added

* deleted img folder

* modified icon-sizes, added tab-navigating outline for More-button

* deleted commented css

* corrected  the stretch effect of video-icon

* Changed using img tag in css to selection by class

* object-fit: cover ==>  object-fit: contain;

* removed alt-text for icons

* classes corrected and experiments over css

* lesser changes to css while experimenting

* input/label ordered, updated css for rect. offset
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants