Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added files #309

Merged
merged 6 commits into from
Sep 4, 2022
Merged

Added files #309

merged 6 commits into from
Sep 4, 2022

Conversation

chernetskyi8704
Copy link
Contributor

DOM

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

@github-actions
Copy link

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure you haven't made common mistakes

Universal recommendations:

  • Give variables and functions meaningful names. Avoid generic names like item, element, key, object, array or their variations. Exception: helper functions that are specifically and intentionally designed to be multipurpose.
  • Function names should start with a verb as they denote actions; variables are normally nouns; boolean variables/functions start with is, does, has etc; variable containing multiple entities and functions returning lists contain entity name in plural form.
  • Have consistent code style and formatting. Employ Prettier to do all dirty work for you.
  • Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

Also take a note of the requirements above and follow them in all your future projects.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

@chernetskyi8704
Copy link
Contributor Author

chernetskyi8704 commented Aug 26, 2022

Had checked my code for common mistakes.

@madmaxWMFU madmaxWMFU self-assigned this Aug 27, 2022
Copy link
Contributor

@madmaxWMFU madmaxWMFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. See some comments below.

 const renderContent = (pasta) => {
     const {name, image, .....} = pasta;
    const template = `${name} .....`;
     //insert to mainContentWrap 
 }

  const getContent = ({ target }) => {
      if( .... ) {
           const selectedPasta = contentData.find(pasta => pasta.name === target.innerText);
           renderContent(selectedPasta);
      }
  }
  menu.addEventListener('click', getContent)

@chernetskyi8704 chernetskyi8704 force-pushed the side-menu-task branch 2 times, most recently from 1582ede to a8d899a Compare August 30, 2022 11:59
Copy link
Contributor

@madmaxWMFU madmaxWMFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do a little change in the code.
Separate event listener and function.
Create separate functions:

  • renderData()
  • getSelectData()
  • cleanContent()
  • toglgleActiveMenuItem()

…iveMenuItem, renderData, cleanContent, getSelectData
@chernetskyi8704
Copy link
Contributor Author

Thanks for the comment. I was trying to figure out how to implement this functionality and got this, I'm not quite sure if it's right, but I couldn't think of any other way.

Copy link
Contributor

@madmaxWMFU madmaxWMFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I approve of your work. Good luck with future tasks!

@madmaxWMFU madmaxWMFU merged commit 625b16c into kottans:main Sep 4, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants