Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Submitting the "Hooli-style Popup" task for review #365

Merged
merged 6 commits into from
Oct 4, 2022

Conversation

VikTorNik
Copy link
Contributor

Hooli-style Popup

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

@github-actions
Copy link

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure you haven't made common mistakes.

Universal recommendations:

  • Give variables and functions meaningful names. Avoid generic names like item, element, key, object, array or their variations. Exception: helper functions that are specifically and intentionally designed to be multipurpose.
  • Function names should start with a verb as they denote actions; variables are normally nouns; boolean variables/functions start with is, does, has etc; variable containing multiple entities and functions returning lists contain entity name in plural form.
  • Have consistent code style and formatting. Employ Prettier to do all dirty work for you.
  • Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

Also take a note of the requirements above and follow them in all your future projects.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

@VikTorNik
Copy link
Contributor Author

Hey!
I fixed the bug.
Please, review.
Sincerely, Viktor

@VikTorNik
Copy link
Contributor Author

Hey!
Removed redundant files.
Please, review.
Sincerely, Viktor

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

submissions/VikTorNik/html-css-popup/index.html Outdated Show resolved Hide resolved
submissions/VikTorNik/html-css-popup/index.html Outdated Show resolved Hide resolved
submissions/VikTorNik/html-css-popup/index.html Outdated Show resolved Hide resolved
submissions/VikTorNik/html-css-popup/index.html Outdated Show resolved Hide resolved
submissions/VikTorNik/html-css-popup/null_style.scss Outdated Show resolved Hide resolved
submissions/VikTorNik/html-css-popup/style.scss Outdated Show resolved Hide resolved
submissions/VikTorNik/html-css-popup/style.scss Outdated Show resolved Hide resolved
submissions/VikTorNik/html-css-popup/style.scss Outdated Show resolved Hide resolved
@A-Ostrovnyy A-Ostrovnyy self-assigned this Sep 15, 2022
@VikTorNik
Copy link
Contributor Author

Good evening!
Thanks for the long list of comments.
It was interesting to learn how to do it correctly.
I fixed the bug.
Please, review.
Sincerely, Viktor

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

submissions/VikTorNik/html-css-popup/index.html Outdated Show resolved Hide resolved
submissions/VikTorNik/html-css-popup/style.scss Outdated Show resolved Hide resolved
@VikTorNik
Copy link
Contributor Author

Good evening!
I reworked the menu a bit and fixed the bugs.
Please, review.
Sincerely, Viktor

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress!

submissions/VikTorNik/html-css-popup/index.html Outdated Show resolved Hide resolved
@VikTorNik
Copy link
Contributor Author

Good evening!
I fixed the bugs.
Please, review.
Sincerely, Viktor

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@A-Ostrovnyy A-Ostrovnyy merged commit 308e486 into kottans:main Oct 4, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants