Frogger-game #55
Frogger-game #55
Conversation
There was a problem hiding this comment.
@DaniaB24 well done!
A couple of improvements and we're done.
P.S. Please also remove comments.
| document.getElementById('score').innerHTML = | ||
| ` | ||
| <div> | ||
| <p>Score:<span>${count}</span></p> | ||
| </div> | ||
| ` |
There was a problem hiding this comment.
The class shouldn't be aware of the specificity of the environment it operates in.
The game engine doesn't offer an appropriate method to us. Let's define a global function for this and pretend it is a part of the game engine.
There was a problem hiding this comment.
thanks for review! I already fix)
There was a problem hiding this comment.
@DaniaB24 well done.
Check the comment below re "magic numbers" and take this a learning for similar cases you may deal with.
| enemy1 = new Enemy(-100, 60, 100, player), | ||
| enemy2 = new Enemy(-100, 143, 25, player), | ||
| enemy3 = new Enemy(-100, 228, 77, player), |
There was a problem hiding this comment.
Always add some semantics to "magic numbers". I guess, all -100 and 100 can be effetively replaced with -CELL_WIDTH and CELL_WIDTH. Remaining numbers remain mysterious. As a peer developer I would love to understand the logic behind them to be able to add more enemies easily wuthout trying to decipher the logic behind calculations.
frogger-game
Demo |
Code base